feat(ic-nervous-system-agent): Add submit_proposal helper
#3451
+147
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).
To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:
-
Done.
-
No canister behavior changes.
anchpop
changed the title
anchpop
dismissed
github-actions[bot]’s stale review
No canister behavior changes
anchpop
changed the title
submit_proposal helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting proposals is a common pattern within the nervous system integration tests, and we will soon be doing it even more within the SNS CLI. So it makes sense to have a helper function for it in
ic-nervous-system-agent.There is one nuance to this.
ic_agent::Agentstores the identity of the sender within it. But pocketic functions take the sender as an argument. Previously, inic-nervous-system-agent, we just assumed the sender would always be the anonymous principal, but obviously this won't work for submitting proposals. So this PR also introduces a way to specify the sender for pocketic through the newPocketIcAgenttype.