chore(ckbtc): add check_transaction_query method to Bitcoin checker #3454
+398
−119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpahlavi
force-pushed
the
lpahlavi/XC-194-query-retrieve-check-transaction-status
branch
2 times, most recently
from
f4bfb78 to
5354b6f
Compare
lpahlavi
force-pushed
the
lpahlavi/XC-194-query-retrieve-check-transaction-status
branch
from
5354b6f to
0331d1d
Compare
lpahlavi
force-pushed
the
lpahlavi/XC-194-query-retrieve-check-transaction-status
branch
from
0331d1d to
3184c66
Compare
lpahlavi
added
the
CI_ALL_BAZEL_TARGETS
|
@gregorydemay Thanks a lot for the feedback! I've implemented your suggested changes, and will wait for @ninegua's +1 before adding all of the required tests. |
ninegua
reviewed
Jan 27, 2025
lpahlavi
commented
Jan 27, 2025
ninegua
approved these changes
Jan 31, 2025
gregorydemay
approved these changes
Feb 6, 2025
lpahlavi
deleted the
lpahlavi/XC-194-query-retrieve-check-transaction-status
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(XC-194) Query interface to retrieve check_transaction status.
The check_transaction call requires cycles to execute due to to the HTTP outcalls it has to perform. However, in the event a transaction and all of its inputs have already been loaded to the cache in heap memory, no HTTP calls are required. This new query method therefore checks whether a transaction status may be obtained using only cached information, and if so, returns it without charging any cycles.