This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
fix: bound delegation depth in verify_response #241
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current definition of
verify_response
for replica-signed queries allows for nested delegations in which case the canister ranges fetched from the delegation might not be signed by the root subnet. This PR fixes this security vulnerability by limiting the delegation depth to one.There's a separate PR bounding the delegation depth to one globally. This PR is void if the delegation depth is bounded globally.