Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

restrict nonce to be of length at most 32 #249

Merged
merged 5 commits into from
Nov 21, 2023
Merged

restrict nonce to be of length at most 32 #249

merged 5 commits into from
Nov 21, 2023

Conversation

mraszyk
Copy link
Contributor

@mraszyk mraszyk commented Nov 14, 2023

This MR restrict the maximum length of a nonce in a request to 32 since 32 bytes are supposed to provide enough randomness.

@mraszyk mraszyk requested a review from a team as a code owner November 14, 2023 16:42
Dfinity-Bjoern
Dfinity-Bjoern reviewed Nov 21, 2023
View reviewed changes
spec/index.md Outdated Show resolved Hide resolved
Dfinity-Bjoern
Dfinity-Bjoern approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@Dfinity-Bjoern Dfinity-Bjoern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed the mild backward incompatibility, seems to have no practical impact and is merged on the replica side already.

@mraszyk mraszyk merged commit 2bbd95f into master Nov 21, 2023
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Dfinity-Bjoern Dfinity-Bjoern Dfinity-Bjoern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mraszyk @Dfinity-Bjoern