-
Notifications
You must be signed in to change notification settings - Fork 20
feat: allow System API method in_replicated_execution to run during canister_start #260
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please update this section https://khsfq-wqaaa-aaaak-qckvq-cai.icp0.io/docs#system-api-imports
Done. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Is this already merged in the replica code? Then I could approve and we can merge this PR in (after updating the changelog).
I have an open MR for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating the spec! @maksymar
🤖 Here's your preview: https://tsg2i-6qaaa-aaaak-qcpwa-cai.icp0.io/docs |
This PR allows a system API method
in_replicated_execution
to be executed duringcanister_start
.