Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

feat: allow System API method in_replicated_execution to run during canister_start #260

Merged
merged 4 commits into from
Dec 11, 2023

Conversation

maksymar
Copy link
Contributor

@maksymar maksymar commented Dec 11, 2023

This PR allows a system API method in_replicated_execution to be executed during canister_start.

@maksymar maksymar marked this pull request as ready for review December 11, 2023 11:36
@maksymar maksymar requested a review from a team as a code owner December 11, 2023 11:36
Copy link
Contributor

@mraszyk mraszyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maksymar
Copy link
Contributor Author

maksymar commented Dec 11, 2023

Could you please update this section https://khsfq-wqaaa-aaaak-qckvq-cai.icp0.io/docs#system-api-imports

Done. PTAL.

@maksymar maksymar requested a review from mraszyk December 11, 2023 11:46
Copy link
Contributor

@mraszyk mraszyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is this already merged in the replica code? Then I could approve and we can merge this PR in (after updating the changelog).

@maksymar
Copy link
Contributor Author

Is this already merged in the replica code? Then I could approve and we can merge this PR in (after updating the changelog).

I have an open MR for that.

@maksymar maksymar requested a review from mraszyk December 11, 2023 11:58
Copy link
Contributor

@dfinity-berestovskyy dfinity-berestovskyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@mraszyk mraszyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the spec! @maksymar

@maksymar maksymar merged commit 74c42ee into master Dec 11, 2023
4 checks passed
Copy link

🤖 Here's your preview: https://tsg2i-6qaaa-aaaak-qcpwa-cai.icp0.io/docs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants