This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
feat: [IC-272] canister logging #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sesi200
reviewed
Dec 14, 2023
sesi200
reviewed
Dec 14, 2023
sesi200
reviewed
Dec 14, 2023
mraszyk
reviewed
Dec 14, 2023
mraszyk
reviewed
Dec 14, 2023
mraszyk
reviewed
Dec 14, 2023
mraszyk
reviewed
Dec 14, 2023
mraszyk
reviewed
Dec 14, 2023
mraszyk
reviewed
Dec 14, 2023
mraszyk
reviewed
Dec 14, 2023
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ielashi
reviewed
Dec 14, 2023
oggy-dfin
reviewed
Dec 18, 2023
oggy-dfin
reviewed
Dec 18, 2023
mraszyk
reviewed
Jan 15, 2024
This comment was marked as resolved.
This comment was marked as resolved.
|
hi all, the feature is going to be available on the next dfx release, I suppose we can move forward with merging this PR. please take another look and LGTM! |
mraszyk
reviewed
Mar 25, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Dfinity-Bjoern
approved these changes
Apr 16, 2024
|
Really looking forward to this feature! |
mraszyk
reviewed
May 20, 2024
This comment was marked as resolved.
This comment was marked as resolved.
mraszyk
reviewed
May 20, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the API changes needed to support MVP for canister logging.