Implementing review feedback

.github/workflows/canister-tests.yml

@@ -486,13 +486,14 @@ jobs:
           # Copy example to make sure it does not rely on living inside the II repo
           builddir=$(mktemp -d)
           cp -r ./demos/using-dev-build/. "$builddir"
+          
+          ii_wasm="$PWD/internet_identity_dev.wasm"
+          ii_did="$PWD/src/internet_identity/internet_identity.did"
+          
           pushd "$builddir"
 
           # Install npm deps
           npm ci
-
-          ii_wasm="$GITHUB_WORKSPACE"/internet_identity_dev.wasm
-          ii_did="$GITHUB_WORKSPACE"/src/internet_identity/internet_identity.did
           sed -i "s;https://github.com/dfinity/internet-identity/releases/latest/download/internet_identity_dev.wasm;$ii_wasm;" ./dfx.json
           sed -i "s;https://github.com/dfinity/internet-identity/releases/latest/download/internet_identity.did;$ii_did;" ./dfx.json
 

demos/using-dev-build/test.ts

@@ -7,7 +7,7 @@
  */
 
 import * as fs from "fs";
-import { ChildProcess, spawn } from "child_process";
+import { ChildProcess, spawn, execSync } from "child_process";
 
 // Port and URL for II and the sign in app, then exported to the tests
 const II_DAPP_PORT = 8086;
@@ -57,16 +57,9 @@ function parseCanisterIDs(): CanisterIDs {
   }
 }
 
-async function getReplicaHost(): Promise<string> {
-  let proc = spawn("dfx", ["info", "webserver-port"]);
-  let result = "";
-  proc.stdout.on("data", (data) => (result += data.toString()));
-  return new Promise((resolve) =>
-    proc.stdout.on("close", (code) => {
-      console.log("process exited with exit code " + code);
-      resolve(`http://localhost:${result}`);
-    })
-  );
+function getReplicaHost(): string {
+  let port = execSync("dfx info webserver-port");
+  return `http://localhost:${port}`;
 }
 
 /*
@@ -89,14 +82,14 @@ function spawnProxy(
   ]);
 }
 
-async function main() {
+function main() {
   // Read values and spawn proxy
   const canisterIds = parseCanisterIDs();
   console.log(
     `Using canister IDs: internet_identity: ${canisterIds.internetIdentity}, webapp: ${canisterIds.webapp}`
   );
 
-  const replicaHost = await getReplicaHost();
+  const replicaHost = getReplicaHost();
   console.log(`Using replica host: ${replicaHost}`);
 
   const proxy = spawnProxy(canisterIds, replicaHost);