Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test-app config #1009

Merged
merged 2 commits into from
Nov 14, 2022
Merged

Update test-app config #1009

merged 2 commits into from
Nov 14, 2022

Conversation

nmattia
Copy link
Collaborator

@nmattia nmattia commented Nov 14, 2022

This updates the test-app config to use the correct replica port (now independent of dfx.json since
#1001) and renames the develop script to start for consistency with the II dev server.

@nmattia nmattia marked this pull request as ready for review November 14, 2022 09:04
Copy link
Contributor

@frederikrothenberger frederikrothenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

This updates the test-app config to use the correct replica port (now
independent of dfx.json since
#1001) and renames the
`develop` script to `start` for consistency with the II dev server.
@nmattia nmattia force-pushed the nm-test-app-cleanup branch from 969c8fa to 26b0e69 Compare November 14, 2022 10:20
@nmattia nmattia enabled auto-merge (squash) November 14, 2022 14:35
@nmattia nmattia merged commit 20c7fa1 into main Nov 14, 2022
@nmattia nmattia deleted the nm-test-app-cleanup branch November 14, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants