-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Google JWT verification and OpenID Google client id init parameter. #2780
Conversation
…o sea-snake/verify-google-jwt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments. Code looks good, I wonder about the usage of the env var.
…tensive test coverage.
…tensive test coverage.
…o sea-snake/verify-google-jwt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add the new field to src/internet_identity/internet_identity.did
manually.
For now, that's not created automatically, but we have a test to check compatibility.
Then, there should be an automatic action to add the delcaraions in JS and TS.
Implement Google JWT verification and OpenID Google client id init parameter.
Changes
Tests
🟡 Some screens were changed