Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Google JWT verification and OpenID Google client id init parameter. #2780

Merged
merged 22 commits into from
Jan 15, 2025

Conversation

sea-snake
Copy link
Contributor

@sea-snake sea-snake commented Jan 13, 2025

Implement Google JWT verification and OpenID Google client id init parameter.

Changes

  • Implemented verify method in openid module.
  • Implemented verify method in google module, called by the above.
  • Implemented OpenID Google client id init parameter.

Tests

  • Verify signature
  • Verify validity window
  • Verify issuer
  • Verify audience
  • Verify nonce

🟡 Some screens were changed

@sea-snake sea-snake requested a review from lmuntaner January 14, 2025 06:51
Copy link
Collaborator

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments. Code looks good, I wonder about the usage of the env var.

src/internet_identity/build.rs Outdated Show resolved Hide resolved
src/internet_identity/src/openid.rs Outdated Show resolved Hide resolved
src/internet_identity/src/openid/google.rs Outdated Show resolved Hide resolved
src/internet_identity/src/openid/google.rs Outdated Show resolved Hide resolved
src/internet_identity/src/openid/google.rs Show resolved Hide resolved
src/internet_identity/src/main.rs Outdated Show resolved Hide resolved
src/internet_identity/src/openid.rs Show resolved Hide resolved
src/internet_identity/src/openid.rs Outdated Show resolved Hide resolved
src/internet_identity/src/openid/google.rs Show resolved Hide resolved
src/internet_identity/src/openid/google.rs Outdated Show resolved Hide resolved
src/internet_identity/src/openid/google.rs Outdated Show resolved Hide resolved
src/internet_identity/src/openid/google.rs Outdated Show resolved Hide resolved
src/internet_identity/src/openid/google.rs Outdated Show resolved Hide resolved
src/internet_identity/src/openid/google.rs Show resolved Hide resolved
Copy link
Collaborator

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add the new field to src/internet_identity/internet_identity.did manually.

For now, that's not created automatically, but we have a test to check compatibility.

Then, there should be an automatic action to add the delcaraions in JS and TS.

src/internet_identity/tests/integration/config.rs Outdated Show resolved Hide resolved
@sea-snake sea-snake requested a review from lmuntaner January 15, 2025 14:29
@sea-snake sea-snake changed the title Implement Google JWT verification and build time environment variables. Implement Google JWT verification and OpenID Google client id init parameter. Jan 15, 2025
@sea-snake sea-snake added this pull request to the merge queue Jan 15, 2025
Merged via the queue into main with commit 760f271 Jan 15, 2025
68 checks passed
@sea-snake sea-snake deleted the sea-snake/verify-google-jwt branch January 15, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants