Do not use cancelled RP IDs for recovery device #2813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LXIF @sea-snake please review |
sea-snake
approved these changes
Jan 23, 2025
LXIF
approved these changes
Jan 23, 2025
lmuntaner
deleted the
lm-recovery-device-without-cancelled-rp-ids-storage
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If a user has a cancelledRpId and that is the origin where the recovery device was registered, then the recovery wouldn't work because it would be filtered out.
We don't track the cancelled RP IDs for the recovery devices and we don't need to because there is only one recovery device.
In this PR, I added a flag to
fromWebauthnCredentialsto skip reading and storing cancelled RP IDs.Changes
fromWebauthnCredentialsand skip reading and storing cancelled RP IDs when set totrue.Tests
🟡 Some screens were changed