Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common origin when registering #2819

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Common origin when registering #2819

merged 1 commit into from
Jan 28, 2025

Conversation

lmuntaner
Copy link
Collaborator

@lmuntaner lmuntaner commented Jan 27, 2025

Motivation

Make sure that the metadata's origin matches the devices origin and the actual RP ID on the passkey manager (iCloud, 1Password, etc)

Changes

  • Add an origin parameter to passkeyAuthnMethodData which creates the device's metadata.
  • Add an origin parameter to savePasskeyOrPin and use it to calculate the RP ID for constructIdentity.
  • Use a common variable to pass the same origin to passkeyAuthnMethodData and savePasskeyOrPin.

Tests

Tested in beta domains by creating one new identity in ic0.app and another in internetcomputer.org and checking that the origin matched the expected. Metadata is private data. I couldn't check that.


🟡 Some screens were changed

@lmuntaner lmuntaner requested a review from sea-snake January 27, 2025 16:04
@lmuntaner lmuntaner marked this pull request as ready for review January 27, 2025 16:04
@lmuntaner
Copy link
Collaborator Author

@sea-snake please review

@lmuntaner lmuntaner added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit be9eee2 Jan 28, 2025
67 checks passed
@lmuntaner lmuntaner deleted the lm-origin-authn-method-data branch January 28, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants