Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make sure that the metadata's
origin
matches the devicesorigin
and the actual RP ID on the passkey manager (iCloud, 1Password, etc)Changes
origin
parameter topasskeyAuthnMethodData
which creates the device's metadata.origin
parameter tosavePasskeyOrPin
and use it to calculate the RP ID forconstructIdentity
.passkeyAuthnMethodData
andsavePasskeyOrPin
.Tests
Tested in beta domains by creating one new identity in
ic0.app
and another ininternetcomputer.org
and checking that theorigin
matched the expected. Metadata is private data. I couldn't check that.🟡 Some screens were changed