Show chasm instead of tooltip for alternative origin #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmattia
force-pushed
the
nm-alternative-dropdown
branch
2 times, most recently
from
d58d668 to
bb12127
Compare
meodai
reviewed
Oct 10, 2022
| padding: 2rem; | ||
| } | ||
|
|
||
| .c-chasm__arrow { |
There was a problem hiding this comment.
I would go with the SVG as originally planned or a clip-path. We will have more styling options in the future. PS: we have variables for z-index's
There was a problem hiding this comment.
Alright, that's way out of my league, will let you do that!
meodai
approved these changes
Oct 10, 2022
This shows a "chasm" (which splits the card open to reveal details) instead of a tooltip on the authenticate screen. This makes the screen a little sleeker and ensures mobile users can display the details too. The wording is changed a bit to make the information more useful and understandable.
nmattia
force-pushed
the
nm-alternative-dropdown
branch
from
bd3e1a4 to
34716ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #927
This shows a "chasm" (which splits the card open to reveal details) instead of a tooltip on the authenticate screen.
Screen.Recording.2022-10-10.at.12.10.11.mov
This makes the screen a little sleeker and ensures mobile users can display the details too. The wording is changed a bit to make the information more useful and understandable.