Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: mention #system_unknown #686

Merged
merged 3 commits into from
Jan 28, 2025
Merged

chore: mention #system_unknown #686

merged 3 commits into from
Jan 28, 2025

Conversation

ggreif
Copy link
Contributor

@ggreif ggreif commented Jan 28, 2025

... it will be returned in the future

@ggreif
chore: mention #system_unknown
033b796 
... it will be returned in the future
@ggreif ggreif requested a review from a team as a code owner January 28, 2025 10:26
@ggreif ggreif self-assigned this Jan 28, 2025
@ggreif ggreif requested a review from crusso January 28, 2025 10:27
@ggreif ggreif enabled auto-merge (squash) January 28, 2025 10:27
@ggreif ggreif added the documentation Improvements or additions to documentation label Jan 28, 2025
@ggreif ggreif mentioned this pull request Jan 28, 2025
Draft
16 tasks
ggreif
ggreif commented Jan 28, 2025
View reviewed changes
src/Error.mo Outdated Show resolved Hide resolved
crusso
crusso reviewed Jan 28, 2025
View reviewed changes
Copy link
Contributor

@crusso crusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we add the variant, then there must be some other code that needs adjusting to map error code 6 (or whatever) to the new variant, and higher ones to #future n for n > 6.

@ggreif
Copy link
Contributor Author

ggreif commented Jan 28, 2025 •
edited
Loading

If we add the variant, then there must be some other code that needs adjusting to map error code 6 (or whatever) to the new variant, and higher ones to #future n for n > 6.

Sure, that is being taken care of on the motoko side. See: https://github.com/dfinity/motoko/pull/4608/files#diff-167dac01f54c5bf1ace6a98be9cdafa68c6159dedacaf16a1389ce500ab66403R5455

Removed the auto-merge, and will merge when the other side is on master. Users won't see #future 6 anyway, since master cannot send best-effort messages (yet). So we could as well merge this now...

@ggreif ggreif disabled auto-merge January 28, 2025 12:42
rvanasa
rvanasa approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@rvanasa rvanasa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamping.

@ggreif ggreif enabled auto-merge (squash) January 28, 2025 16:26
@ggreif ggreif merged commit dc363a8 into master Jan 28, 2025
6 checks passed
@ggreif ggreif deleted the gabor/system_unknown branch January 28, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crusso crusso crusso left review comments

@rvanasa rvanasa rvanasa approved these changes

Assignees

@ggreif ggreif

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggreif @crusso @rvanasa