Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(security): enable certified calls for ICP/XDR conversion rate #6292

Merged
merged 2 commits into from
Jan 30, 2025
Merged

fix(security): enable certified calls for ICP/XDR conversion rate #6292

merged 2 commits into from
Jan 30, 2025

Conversation

yhabib
Copy link
Contributor

@yhabib yhabib commented Jan 29, 2025 •
edited by jira bot
Loading

Motivation

It has been flagged as a security concern not to use a certified query when reading the ICP to XDR conversion rate.

This is a follow up of dfinity/ic-js#830 to make the call as a certified one.

SECFIND-421

Changes

  • Pass the certified flag to getIcpToCyclesConversionRate to make it an update call

Tests

  • Updated unit test to check that the flag is provided

Todos

  • Add entry to changelog (if necessary).
    Not necessary

@yhabib yhabib changed the base branch from main to housekeeping/ic-js/next January 29, 2025 22:00
@yhabib yhabib marked this pull request as ready for review January 29, 2025 22:01
@yhabib yhabib requested a review from a team as a code owner January 29, 2025 22:01
Base automatically changed from housekeeping/ic-js/next to main January 30, 2025 09:07
@dskloetd
Copy link
Contributor

Did #6290 get mixed in here?

@yhabib yhabib force-pushed the fix/icp-xdr-certified branch from c92bc78 to 9d04f29 Compare January 30, 2025 09:40
@yhabib yhabib force-pushed the fix/icp-xdr-certified branch from 9d04f29 to bf49922 Compare January 30, 2025 10:44
@yhabib yhabib added this pull request to the merge queue Jan 30, 2025
Merged via the queue into main with commit 1dcd6a4 Jan 30, 2025
32 checks passed
@yhabib yhabib deleted the fix/icp-xdr-certified branch January 30, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dskloetd dskloetd dskloetd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhabib @dskloetd