-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: build icrc1_transfer consent message if target does not implement ICRC-21 #360
Merged
peterpeterparker
merged 37 commits into
main
from
feat/build_icrc1_transfer_consent_message
Dec 27, 2024
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
eb8406b
feat: build icrc1_transfer consent message if target does not impleme…
peterpeterparker 1bfce8c
feat: i18n
peterpeterparker 7e3a88c
feat: title and amount
peterpeterparker 509a1bf
feat: with subaccount
peterpeterparker b83570d
feat: with subaccount
peterpeterparker 3866a64
feat: to account
peterpeterparker 335733c
feat: fee
peterpeterparker 772a5b8
feat: memo
peterpeterparker 083c414
chore: lint
peterpeterparker 8a8c972
feat: format utils
peterpeterparker 6c1543f
feat: mapper
peterpeterparker a587748
feat: min two decimals for readability
peterpeterparker e338fa3
feat: format amount
peterpeterparker ff5e86d
feat: fee format and fallback
peterpeterparker c81046e
feat: token symbol
peterpeterparker afd590c
refactor: extract consent message
peterpeterparker ceeb02a
feat: use builders
peterpeterparker 4991d3d
chore: rm test
peterpeterparker 828fceb
chore: merge main
peterpeterparker e8595ba
chore: todo
peterpeterparker 77fdc04
build: bump ic next
peterpeterparker a5998cf
feat: builder return object for consent message
peterpeterparker 5fbd709
feat: types
peterpeterparker 8ba0975
Merge branch 'main' into feat/build_icrc1_transfer_consent_message
peterpeterparker a4aa1b5
chore: merge main
peterpeterparker 4eceb12
docs: builder
peterpeterparker c666d20
test: ledger in signer api
peterpeterparker 0eaa766
test: bubble error
peterpeterparker fa87ee4
chore: merge main
peterpeterparker b017e79
Merge branch 'main' into feat/build_icrc1_transfer_consent_message
peterpeterparker 95b714d
refactor: method instead of function and rename fallback
peterpeterparker 0b50366
test: error with builder
peterpeterparker 9ce617c
chore: fmt
peterpeterparker 149220e
test: throws return
peterpeterparker 5a92b3f
test: approves
peterpeterparker b42c3bd
Merge branch 'main' into feat/build_icrc1_transfer_consent_message
peterpeterparker ff334ec
chore: update todo
peterpeterparker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
import {buildContentMessageIcrc1Transfer} from '../builders/signer.builders'; | ||
import {SignerBuilderFn, SignerBuilderMethods} from '../types/signer-builders'; | ||
|
||
export const SIGNER_BUILDERS: Record<SignerBuilderMethods, SignerBuilderFn> = { | ||
icrc1_transfer: buildContentMessageIcrc1Transfer | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any i18n reference needed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need, I would say. This particular error also not handled in any specific way since it's the original error—the lack of ICRC-21 support—which will be bubbled up to the caller.
All error messages are currently provided in English. I'm not sure what criteria would be used for selecting another language. Maybe something to improve globally in the future, in that sense good point!