Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(IDX): update comment logic #78

Merged
merged 5 commits into from
Dec 12, 2024
Merged

refactor(IDX): update comment logic #78

merged 5 commits into from
Dec 12, 2024

Conversation

cgundy
Copy link
Member

@cgundy cgundy commented Dec 9, 2024

In trying to debug some CLA issues, I noticed that the logic is very convoluted, so I made some updates. I changed some function names, but the main change is that I removed the step that checks the name of the bot, so we won't run into issues if we need to change the bot that triggers this workflow again.

@cgundy cgundy marked this pull request as ready for review December 12, 2024 09:59
@cgundy cgundy requested a review from a team as a code owner December 12, 2024 09:59
@cgundy cgundy merged commit 7ea52c6 into main Dec 12, 2024
6 checks passed
@cgundy cgundy deleted the update-comment-logic branch December 12, 2024 10:15
cgundy added a commit that referenced this pull request Dec 12, 2024
cgundy added a commit that referenced this pull request Dec 12, 2024
@cgundy cgundy restored the update-comment-logic branch December 16, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants