Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Includes motoko-dev-server in new motoko projects #3038

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

krpeacock
Copy link
Contributor

@krpeacock krpeacock commented Mar 22, 2023

Description

The Motoko project now includes a few new quality-of-life enhancements:

  • npm start now starts the motoko-dev-server in addition to the webpack server.
    • This means that you can now use the motoko-dev-server to hot-reload your motoko canisters and frontends as you make changes.
  • mops package manager is now included and configured
    • This installs the motoko-base and test libraries
  • hello world now includes a lib.mo and lib.test.mo file
    • This demonstrates write tests for your canisters and run them with npm run test:motoko

Fixes #SDK-991

How Has This Been Tested?

Manually compiling the rust and motoko new projects

  • dfx deploy
    • visiting the webpage
  • npm start
    • visiting the webpage

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock requested a review from a team as a code owner March 22, 2023 00:04
@krpeacock krpeacock marked this pull request as draft March 22, 2023 00:05
@krpeacock
Copy link
Contributor Author

Noting here - mops sources failed during CI with exit status: 254. It may be that mops isn't mature enough yet

@rvanasa
Copy link
Contributor

rvanasa commented Mar 23, 2023

Which version of Node.js is being used in the CI?

(Update: it's Node 18.x)

@rvanasa
Copy link
Contributor

rvanasa commented May 16, 2023

@krpeacock @ZenVoich @dfx-json, these CI errors are apparently caused by the replica timing out rather than an issue with Mops (relevant log output).

I temporarily switched the default mops.toml dependencies to use GitHub repositories to unblock progress on renovating the dfx new command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants