Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update keyring to version 3 #4057

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

anchpop
Copy link
Contributor

@anchpop anchpop commented Jan 7, 2025

What

This PR updates the dependency keyring to version 3, from version 1.2 before.

Why

Having such an old version of keyring was causing the SDK to have duplicate versions of many dependencies, because the old version of keyring was pulling in old versions of lots of other libraries.

For example, previously the SDK was depending on rustix 0.37 as well as rustix 0.38. It was also depending on two versions of cipher, two versions of aes, two versions of hmac, two versions of proc-macro-crate, two versions of toml, two versions of socket2, two versions of async-lock, two versions of fastrand, and two versions of nix.

After this PR, the SDK will only depend on one version of each of these libraries. This will speed up build times and probably make the binary slightly smaller. At least, I think it should, I didn't measure it. One potential issue is that this PR starts us vendoring openssl - but I have no idea how to avoid this (it seems like we get CI errors otherwise). On the other hand, it seems like a smaller problem than having so many duplicate dependencies, and I will put some more time into trying to figure out how to avoid it.

How Has This Been Tested?

cargo clippy and cargo test

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly. (not necessary I think)
  • I have made corresponding changes to the documentation. (none necessary I think)

@anchpop anchpop requested a review from a team as a code owner January 7, 2025 18:12
@anchpop anchpop force-pushed the @anchpop/update-keyring branch 3 times, most recently from ae10cf0 to 08415fe Compare January 7, 2025 18:28
@anchpop anchpop force-pushed the @anchpop/update-keyring branch 6 times, most recently from 88ee9b6 to c853aa2 Compare January 7, 2025 19:08
@anchpop anchpop enabled auto-merge (squash) January 7, 2025 19:11
@anchpop anchpop disabled auto-merge January 7, 2025 23:11
@anchpop anchpop enabled auto-merge (squash) January 8, 2025 03:48
@anchpop anchpop force-pushed the @anchpop/update-keyring branch from c853aa2 to da19196 Compare January 8, 2025 03:49
@anchpop anchpop disabled auto-merge January 8, 2025 04:12
@anchpop anchpop enabled auto-merge (squash) January 8, 2025 16:09
@anchpop anchpop force-pushed the @anchpop/update-keyring branch from da19196 to f5de085 Compare January 8, 2025 16:15
@anchpop anchpop merged commit 90d18e9 into master Jan 8, 2025
297 checks passed
@anchpop anchpop deleted the @anchpop/update-keyring branch January 8, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants