Skip to content

Commit

Permalink
remove runtime subcommand
Browse files Browse the repository at this point in the history
  • Loading branch information
smohan-dw committed Jan 3, 2025
1 parent bb590df commit 9badf54
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 77 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,15 +94,15 @@ To get your local CORD node up and running, follow these steps:
If you want to run the Braid runtime, use the following command:

```bash
./target/release/cord braid --dev
./target/release/cord --chain braid-dev --dev
```

3. Start the Loom node in development mode:

To run the Loom runtime, use this command:

```bash
./target/release/cord loom --dev
./target/release/cord --chain loom-dev --dev
```

4. Verify your node is up and running successfully by reviewing the output displayed in the terminal.
Expand Down
18 changes: 0 additions & 18 deletions node/cli/src/cli.rs
Original file line number Diff line number Diff line change
Expand Up @@ -80,24 +80,6 @@ pub enum Subcommand {

/// Db meta columns information.
ChainInfo(sc_cli::ChainInfoCmd),

/// Start Braid development node
Braid {
#[clap(long = "dev", required = true, help = "Run the Braid node in development mode")]
dev: bool,
},

/// Start Loom development node
Loom {
#[clap(long = "dev", required = true, help = "Run the Loom node in development mode")]
dev: bool,
},

/// Start Weave development node
Weave {
#[clap(long = "dev", required = true, help = "Run the Weave node in development mode")]
dev: bool,
},
}

#[allow(missing_docs)]
Expand Down
40 changes: 5 additions & 35 deletions node/cli/src/command.rs
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ impl SubstrateCli for Cli {
.unwrap_or("loom")
} else {
match id {
"dev-node-braid" | "dev-node-loom" | "dev-node-weave" => "dev",
"braid-dev" | "loom-dev" | "weave-dev" => "dev",
_ => id,
}
};
Expand All @@ -98,9 +98,9 @@ impl SubstrateCli for Cli {
#[cfg(feature = "weave-native")]
"weave" | "weave-local" => Box::new(chain_spec::weave_local_testnet_config()?),
"dev" => match incoming_id {
"dev-node-braid" => Box::new(chain_spec::braid_development_config()?),
"dev-node-loom" => Box::new(chain_spec::loom_development_config()?),
"dev-node-weave" => Box::new(chain_spec::weave_development_config()?),
"braid-dev" => Box::new(chain_spec::braid_development_config()?),
"loom-dev" => Box::new(chain_spec::loom_development_config()?),
"weave-dev" => Box::new(chain_spec::weave_development_config()?),
_ => Box::new(chain_spec::weave_development_config()?),
},
#[cfg(not(feature = "braid-native"))]
Expand Down Expand Up @@ -155,7 +155,7 @@ fn set_default_ss58_version(spec: &Box<dyn cord_service::ChainSpec>) {

/// Parse command line arguments into service configuration.
pub fn run() -> Result<()> {
let mut cli: Cli = Cli::from_args();
let cli: Cli = Cli::from_args();

match &cli.subcommand {
None => {
Expand All @@ -166,36 +166,6 @@ pub fn run() -> Result<()> {
cord_service::new_full(config, cli).map_err(sc_cli::Error::Service)
})
},
Some(Subcommand::Braid { dev: _ }) => {
cli.run.shared_params.dev = true;
cli.run.shared_params.chain = Some("dev-node-braid".into());
let runner = cli.create_runner(&cli.run)?;
runner.run_node_until_exit(|config| async move {
let chain_spec = config.chain_spec.cloned_box();
set_default_ss58_version(&chain_spec);
cord_service::new_full(config, cli).map_err(sc_cli::Error::Service)
})
},
Some(Subcommand::Loom { dev: _ }) => {
cli.run.shared_params.dev = true;
cli.run.shared_params.chain = Some("dev-node-loom".into());
let runner = cli.create_runner(&cli.run)?;
runner.run_node_until_exit(|config| async move {
let chain_spec = config.chain_spec.cloned_box();
set_default_ss58_version(&chain_spec);
cord_service::new_full(config, cli).map_err(sc_cli::Error::Service)
})
},
Some(Subcommand::Weave { dev: _ }) => {
cli.run.shared_params.dev = true;
cli.run.shared_params.chain = Some("dev-node-weave".into());
let runner = cli.create_runner(&cli.run)?;
runner.run_node_until_exit(|config| async move {
let chain_spec = config.chain_spec.cloned_box();
set_default_ss58_version(&chain_spec);
cord_service::new_full(config, cli).map_err(sc_cli::Error::Service)
})
},
Some(Subcommand::Inspect(cmd)) => {
let runner = cli.create_runner(cmd)?;

Expand Down
22 changes: 0 additions & 22 deletions runtimes/weave/src/genesis_config_presets.rs
Original file line number Diff line number Diff line change
Expand Up @@ -180,25 +180,3 @@ pub fn get_preset(id: &sp_genesis_builder::PresetId) -> Option<Vec<u8>> {
.into_bytes(),
)
}
// pub fn get_preset(id: &sp_genesis_builder::PresetId) -> Option<Vec<u8>> {
// let patch = match id.as_ref() {
// Ok("development") => cord_weave_development_config_genesis(),
// Ok("local_testnet") => cord_weave_local_testnet_genesis(),
// _ => return None,
// };
// Some(
// serde_json::to_string(&patch)
// .expect("serialization to json is expected to work. qed.")
// .into_bytes(),
// )
// }

#[cfg(test)]
mod tests {
use super::*;

#[test]
fn default_parachains_host_configuration_is_consistent() {
default_parachains_host_configuration().panic_if_not_consistent();
}
}

0 comments on commit 9badf54

Please sign in to comment.