fix: Adding statement entry before signing VC #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vikastc <[email protected]>
Signed-off-by: vikastc <[email protected]>
amarts
reviewed
Dec 9, 2024
src/vc.ts
Outdated
| if (options.type === 'affinidi') { | ||
| delete vc.credentialHash; | ||
| // Add statement as id in VC | ||
| const vcId = oldStmt.split(':').slice(0, 3).join(':'); |
There was a problem hiding this comment.
may be this will need to keep the changes as is? they need a ':' in the ID? If not, then OK. Because at least Inji code needed some ':' in ID.
There was a problem hiding this comment.
I tried it with keeping the digest in the statement, but it was not getting verfied in affinidi portal.
Hence, removed the digest from statement
Signed-off-by: vikastc <[email protected]>
|
TODO: Not able to find compatible package for |
Signed-off-by: vikastc <[email protected]>
|
TODO: Will format the code to seperate secp256k1 and ed25519 making ed25519 as default |
Signed-off-by: vikastc <[email protected]>
Signed-off-by: vikastc <[email protected]>
amarts
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.