Fix performance issues #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigerl
requested changes
Nov 28, 2023
src/main/java/org/aksw/iguana/commons/time/DurationLiteral.java
Outdated
Show resolved
Hide resolved
src/main/java/org/aksw/iguana/cc/metrics/impl/AggregatedExecutionStatistics.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander Bigerl <[email protected]>
mcb5637
requested changes
Nov 29, 2023
There was a problem hiding this comment.
As far as i can tell the spec of java.time.Duration matches xsd:dayTimeDuration and not xsd:duration.
(Except if the duration is >= 24 hours. Then java still outputs durations where it should output days. But the representation is still valid and should be accepted on parsing.)
bigerl
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a test of the new iguana version, I noticed that there were some severe performance issues during the processing of the results, after the stresstest has finished. The biggest issue of it was the jena library and the
canonicalmethod inside itsXSDDurationclass, which didn't support nanoseconds as decimal digits for the durations.This PR aims to circumvent this issue by creating our own LiteralType class, which might not be the best solution.
I've also made the QuerySource cache its hashCode, which also caused some performance issues, as the hashCode is needed everytime the id of a Query from a QueryHandler is retrieved. Caching the QuerySource hashCode shouldn't be a problem though, as we don't expect the hashCode to change itself during the benchmark.