fix build on mac #58
Merged
fix build on mac #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liss-h
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
I was pondering if there is a way to do this that gives better error messages, but with the current structure of the library we can't relly use the #error directive (because the header is included by default and you are not expected to include it manually).
The only other option would be to provide an empty struct for the other architectures, but I don't think thats necessarily better.
So with that in mind I'm going to approve this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POBR only changes on non x86 architectures, where it did not work at all before