fix mypy

mypy.ini

@@ -0,0 +1,6 @@
+[mypy]
+python_version = 3.11
+
+[mypy-ebooklib.*]
+ignore_missing_imports = true
+

src/application/dto.py

@@ -20,15 +20,15 @@ def from_chapter(cls, chapter: Chapter):
 
 @attrs.define
 class BookForUploadDTO:
-    format: str
-    book_title: str
-    book_author: str
+    format: str | None
+    book_title: str | None
+    book_author: str | None
 
 
 @attrs.define
 class BookForUploadWithFileDTO(BookForUploadDTO):
     file: SpooledTemporaryFile
-    filename: str
+    filename: str | None
 
 
 @attrs.define
@@ -57,4 +57,3 @@ class CoverFormat(enum.StrEnum):
 class BookCoverFile:
     file: bytes
     format: str
-

src/infrastructure/adapters/book_cover_repo.py

@@ -9,7 +9,7 @@ def __init__(self, path: pathlib.Path):
 
     async def get_cover_file(self, book_id: str) -> dto.BookCoverFile | None:
         file_path, fmt = self._get_file_path_with_cover(book_id)
-        if file_path is None:
+        if file_path is None or fmt is None:
             return None
 
         return dto.BookCoverFile(file=file_path.read_bytes(), format=fmt)

src/infrastructure/epub/load.py

@@ -7,7 +7,7 @@
 from src.infrastructure.epub.sorted import EpubBookWithMethods
 
 
-def load_epub_from_upload(file: SpooledTemporaryFile, filename: str):
+def load_epub_from_upload(file: SpooledTemporaryFile, filename: str | None):
     reader = EpubBookWithUploadFromBinary.from_binary(file, filename)
 
     book = reader.book
@@ -18,7 +18,7 @@ def load_epub_from_upload(file: SpooledTemporaryFile, filename: str):
 
 class EpubBookWithUploadFromBinary(epub.EpubReader):
     @classmethod
-    def from_binary(cls, file: SpooledTemporaryFile, filename: str):
+    def from_binary(cls, file: SpooledTemporaryFile, filename: str | None):
         file_copy = create_file_deepcopy(file)
         reader = cls(filename, {"ignore_ncx": True})
 

src/presentation/entrypoints/book.py

@@ -1,4 +1,5 @@
-from typing import Annotated
+from tempfile import SpooledTemporaryFile
+from typing import Annotated, cast
 
 from fastapi import APIRouter, Depends, UploadFile, Form, Response, Request
 from fastapi_filter import FilterDepends
@@ -34,7 +35,7 @@ async def upload_book(
     book_service: BookService = Depends(get_book_service),
 ) -> BookUploadedResponse:
     upload = dto.BookForUploadWithFileDTO(
-        file=book_file.file,
+        file=cast(SpooledTemporaryFile, book_file.file),
         filename=book_file.filename,
         format=book_file.content_type,
         book_title=title,
@@ -85,4 +86,7 @@ async def get_book_cover(
 ):
     cover = await book_service.get_book_cover(book_id)
 
+    if cover is None:
+        return None
+
     return Response(content=cover.file, media_type=f"image/{cover.format}")

src/presentation/filters/book.py

@@ -10,4 +10,4 @@ class BookFilter(Filter):
     chapter_number__lte: Optional[int] = None
 
     class Constants(Filter.Constants):
-        model = book_table.c
+        model = book_table.c  # type: ignore