-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata and opengraph tags #32
Conversation
…on and object pages
Netlify outputStatic site (preview): https://deploy-preview-32--heritage-tudelft.netlify.app |
Converted to draft while amendments noted during yesterday's call are addressed. |
DO NOT MERGE UNTIL WE HAVE THE META DESCRIPTIONS FROM JULES. |
Some feedback on this PR:
(This was used on the previous site; I made it square for compatibility but you can also use:)
|
Thanks for the feedback @sammeltassen. Please reply if you need any further answers to the points below.
I've consulted @stephenwf who has advised this would be a separate ticket.
Yes I can use this image. For the 'rotating' behaviour, will you rotate the image yourself by editing the code / replacing the image?
Yes
For 'publications' mdx files and the 'about' page mdx file, this is fine.
For Publications, it can use the description and image from the frontmatter. Publications are currently the only pages which are tagged as 'articles'. Does that answer your question?
The ability to link to a specific canvas of an object page by appending
Yes, I will check |
I've now added mdx files for Home, Search, plus Collections, Publications, Exhibitions listings, in #34 so this behaviour will be consistent across the site. |
…umbnail Use the largest thumbnail size in the resource meta file.
MDX files for metadata for all pages without manifests
@sammeltassen Just to double check. |
@funkydunc Looking good, I only noticed that the default imageHeight is incorrect on collection pages. About the |
Well spotted - this has been fixed. If you can let me know when this is good to merge, that would be great, thanks @sammeltassen |
For the url to update automatically to contain the |
Added title, description and opengraph tags to all pages.
Home, About, Search and Listing pages have placeholder description keys in the
en.json
andnl.json
files. These descriptions can be updated later.Using the meta.json file for Exhibition, Object pages. Using the publication file for Publication detail page. Collection page still uses the collection.json as discussed.
Title, Summary and image are pulled from these files to use in the metadata.
It was necessary to remove static prerendering from the Exhibition page via
generateStaticParams
for the time being, in order to usegenerateMetadata
. There may be a workaround to come back to.A breadcrumb style title has been chosen, see slack thread https://digirati.slack.com/archives/CE4B06X9V/p1736778154847079
We later discussed that this would be reversed, and not contain a middle item.
e.g.
TU Delft Academic Heritage
About | TU Delft Academic Heritage
Exhibitions | TU Delft Academic Heritage
Irrigation Knowledge | TU Delft Academic Heritage
Used a png downloaded from Delfts corporate design site, as the og tags require a size to be given so that the image appears a decent size on the social preview, which can't be done with svg.
Made helpers for getting the site name, title and basic metadata to avoid repeating code in many pages.
The metadata helper accepts:
and is used on pages that do not have a dynamic title / description / image that come from a file. For detail pages, the metadata is explicitly defined.
n.b. Currently no object meta files have summary, which is used for the
<meta name="description"
tag, so this tag is missing on Objects.n.b. We are waiting for the descriptions to be provided for the non dynamic pages:
before merging this, to avoid the current placeholder description being indexed.
this shows an example of the tags generated in the page source