Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/del 121 toc 3101 amends #39

Closed
wants to merge 38 commits into from
Closed

Feature/del 121 toc 3101 amends #39

wants to merge 38 commits into from

Conversation

funkydunc
Copy link
Contributor

@funkydunc funkydunc commented Jan 31, 2025 •
edited
Loading

The latest amendments from 31st Jan.

split from #38 following design amendments from this reply onwards: #33 (comment)

Initial load:

  • bar is present at bottom on all devices, displaying Section Label only
  • page shows Exhibition main title at top. No section titles in page.
    image

TOC opens upwards
image

After selecting an entry
image

funkydunc and others added 30 commits January 24, 2025 12:44
@funkydunc
primitive BottomBar component
40365ee
@funkydunc
TOC wip
3ff9362
@funkydunc
TOC wip
399aee7
@funkydunc
debug
ab41f2b
@funkydunc
Headings & Arrows on labelled canvases
ea420d3
@funkydunc
Merge branch 'main' into feature/DEL-121-table-of-contents
b94be53
Automatic publish from github.com/libis/ca_tudelft_iiif
7aac62a
@funkydunc
IntersectionObserver to track scrolling
ec550d5
@funkydunc
set url has on scroll, tidy
ac19cc8
@funkydunc
title bar can open TOC modal
fb40c17
@funkydunc
reinit observers on height change
1a05e59
@funkydunc
key
efaf935
@funkydunc
show hide TOC bar (buggy)
67a64e6
@funkydunc
accessibility
21cd47f
@funkydunc
tidy
03c1aaa
@funkydunc
Merge branch 'main' into feature/DEL-121-table-of-contents
e1668ac
@funkydunc
Merge branch 'feature/hss-history-copy' into feature/DEL-121-table-of…
1231dc6 
…-contents
@funkydunc
tidy
ead9831
@funkydunc
updated on build
327e235
@funkydunc
remove duplicate import
49cd21c
@funkydunc
comment out hiding toc bar
1f81180
@funkydunc
remove async
623ad1d
@funkydunc
move grey bar to top and hide at scroll 0
00404ac
@funkydunc
Correctly centered and responsive bar
c8ba569
@funkydunc
remove extra heading and link to top
417cedc
@funkydunc
modal from top wip
3b84086
@funkydunc
move bar and toc to top. Always open
0cb100c
@funkydunc
Remove unused code for hiding the bar at the top
2f4d1b2
@funkydunc
allow to link back to the top of the page
a4bb3cd
@funkydunc
alignment
f98bfab
@funkydunc funkydunc added deploy-preview PRs tagged with this will deploy a Netlify preview URL debug-build labels Jan 31, 2025
@funkydunc funkydunc marked this pull request as draft January 31, 2025 17:35
@funkydunc funkydunc changed the base branch from main to feature/hss-history-copy January 31, 2025 17:39
@github-actions GitHub Actions
Copy link

Netlify output

Static site (preview): https://deploy-preview-39--heritage-tudelft.netlify.app
IIIF (preview): https://deploy-preview-39--delft-iiif.netlify.app
IIIF Collection (preview): Theseus

@funkydunc
Copy link
Contributor Author

Closing. Work was merged manually into hss-history branch.

@funkydunc funkydunc closed this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
debug-build deploy-preview PRs tagged with this will deploy a Netlify preview URL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@funkydunc