Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ExternalService for unknown Service elements #54

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

donaldgray
Copy link
Member

Added V2 and V3 ExternalService classes. These are used as fallbacks if we need to deserialize an IService and don't have a type to deserialize too. These both inherit from ResourceBase.

The anticipation is that this will be used to map unknown services such as

"services": [
  {
    "id": "https://iiif.wellcomecollection.org/presentation/b18035723#tracking",
    "type": "Text",
    "profile": "http://universalviewer.io/tracking-extensions-profile",
    "label": {
      "en": [
        "Format: Monograph, Institution: n/a, Identifier: b18035723, Digicode: diggenetics, Collection code: n/a"
      ]
    }
  },
  {
    "id": "https://iiif.wellcomecollection.org/presentation/b18035723#timestamp",
    "type": "Text",
    "profile": "https://github.com/wellcomecollection/iiif-builder/build-timestamp",
    "label": {
      "none": [
        "2021-04-29T21:58:28.9247406Z"
      ]
    }
  },
  {
    "id": "https://iiif.wellcomecollection.org/presentation/b18035723#accesscontrolhints",
    "type": "Text",
    "profile": "http://wellcomelibrary.org/ld/iiif-ext/access-control-hints",
    "label": {
      "en": [
        "open"
      ]
    }
  }
]

from https://iiif.wellcomecollection.org/presentation/b18035723

@donaldgray
Copy link
Member Author

Note - I'll add some additional tests around this.

@donaldgray donaldgray marked this pull request as draft November 19, 2024 09:24
@donaldgray donaldgray force-pushed the feature/external_service branch from 0bb9967 to 45bdd0f Compare November 19, 2024 09:24
@donaldgray donaldgray marked this pull request as ready for review November 19, 2024 11:20
@donaldgray donaldgray merged commit 1a02cf1 into main Nov 19, 2024
1 check passed
@donaldgray donaldgray deleted the feature/external_service branch November 19, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants