Merge pull request #814 from digirati-co-uk/feature/NS-57

NS-57 - fixed bug with max contributors
digirati-co-uk · Feb 13, 2024 · 4120461 · 4120461
2 parents 6701383 + 52bf91e
commit 4120461
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 18 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -47,6 +47,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Fixed token refreshing
 - Fixed activity stream pagination (NS-52)
 - Fixed visibility of selectors in document panel
+- Fixed bug with max contributors (NS-57)
 
 ### Changed
 - Add short descriptions for admin Search & Metadata actions + correct site config. page titles (MAD-1466)

diff --git a/services/madoc-ts/src/frontend/shared/capture-models/new/features/AutosaveRevision.tsx b/services/madoc-ts/src/frontend/shared/capture-models/new/features/AutosaveRevision.tsx
@@ -27,15 +27,10 @@ export const AutosaveRevision: React.FC = () => {
     if (isEmpty) {
       return;
     }
-    localforage
-      .setItem(`autosave-${currentRevision.captureModelId}`, currentRevision)
-      .then(value => {
-        console.log('saved!');
-      })
-      .catch(err => {
-        console.log(err);
-        throw new Error(t('Unable to save your submission'));
-      });
+    localforage.setItem(`autosave-${currentRevision.captureModelId}`, currentRevision).catch(err => {
+      console.log(err);
+      throw new Error(t('Unable to save your submission'));
+    });
   });
 
   const [getSavedRevision, rev] = useMutation(async () => {
@@ -62,14 +57,9 @@ export const AutosaveRevision: React.FC = () => {
       importRevision({ revisionRequest: rev.data });
       selectRevision({ revisionId: rev.data.revision.id });
 
-      localforage
-        .removeItem(`autosave-${currentRevision?.captureModelId}`)
-        .then(() => {
-          console.log('Key is cleared!');
-        })
-        .catch(err => {
-          console.log(err);
-        });
+      localforage.removeItem(`autosave-${currentRevision?.captureModelId}`).catch(err => {
+        console.log(err);
+      });
     }
   };
 

diff --git a/services/madoc-ts/src/frontend/site/hooks/use-canvas-user-tasks.ts b/services/madoc-ts/src/frontend/site/hooks/use-canvas-user-tasks.ts
@@ -81,7 +81,7 @@ export function useCanvasUserTasks() {
 
     const maxContributors =
       canvasTask?.maxContributors && canvasTask.totalContributors
-        ? canvasTask.maxContributors >= canvasTask.totalContributors
+        ? canvasTask.maxContributors <= canvasTask.totalContributors
         : false;
 
     // if max contributors reached check that the current user isnt one of them