Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search, filter and sort to resources page #28

Merged
merged 8 commits into from
Mar 2, 2022
Merged

Conversation

flickz
Copy link
Contributor

@flickz flickz commented Feb 14, 2022

Resolves #25 and #33

@flickz flickz self-assigned this Feb 14, 2022
@vercel
Copy link

vercel bot commented Feb 14, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/opencollective/digitalinfrastructure/8uZ5eNatw1gkvUqr1EEyCMdF7CHZ
✅ Preview: https://digitalinfrastructure-git-feat-resources-opencollective.vercel.app

@RichardLitt
Copy link
Member

Thanks, @flickz. The filter doesn't seem to work; what am I missing? Nothing changes when I type something in.

As well, there's only one type of resource. How do I add different types?

@flickz
Copy link
Contributor Author

flickz commented Feb 28, 2022

@RichardLitt I don't know the expected type of resources but if you want to add type to resources in a project, add a type property to the resource object.

export const resources = [
  {
    title: "Detecting At-Risk Software Infrastructure",
    link: "https://blog.communitydata.science/detecting-at-risk-software-infrastructure/",
    linkText: "Read More",
    author: "Kaylea Champion",
    type: ""
  },
];

What are the expected types? I need the list ([]) to implement the type filter which is what is currently missing.

@RichardLitt
Copy link
Member

Thanks Olu. For now, why don't we add: ["website", "talk", "document"]. I can add more as they come up - would it be possible to make the list of possible types dynamic based on the values of all of the type fields?

@flickz flickz changed the title Add search, filter and sort to resources page Add search, filter and sort to resources page and search for project page Mar 1, 2022
@flickz
Copy link
Contributor Author

flickz commented Mar 1, 2022

@RichardLitt Yes, it is possible. I've implemented it now. Go ahead and type field to the project resources. As an example of this, I added type for this project.

0dbd524#diff-75fef3b4800bfdf98e11f7594deee6d79d4a0b7c52315179adf67a79a77d1cfb

@RichardLitt RichardLitt merged commit d48e161 into main Mar 2, 2022
@RichardLitt RichardLitt deleted the feat/resources branch March 2, 2022 11:14
@RichardLitt
Copy link
Member

Looks great to me! Thank you, @flickz.

@flickz flickz changed the title Add search, filter and sort to resources page and search for project page Add search, filter and sort to resources page Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rethink resources page
2 participants