compare: implement --snapshot option for source database #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to compare a source snapshot to the target
dimitri
requested changes
Nov 2, 2023
Comment on lines
+417
to
+429
| if (!pgsql_set_transaction(&src, ISOLATION_REPEATABLE_READ, false, true)) | ||
| { | ||
| /* errors have already been logged */ | ||
| (void) pgsql_finish(&src); | ||
| return false; | ||
| } | ||
|
|
||
| if (!pgsql_set_snapshot(&src, copySpecs->sourceSnapshot.snapshot)) | ||
| { | ||
| /* errors have already been logged */ | ||
| (void) pgsql_finish(&src); | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Can we just use copydb_set_snapshot from snapshot.c?
Comment on lines
+825
to
+828
| /* unset sourceSnapshot snapshot for target */ | ||
| targetSpecs->consistent = false; | ||
| (void) memset(&(targetSpecs->sourceSnapshot.snapshot), 0, sizeof(targetSpecs->sourceSnapshot.snapshot)); | ||
|
|
There was a problem hiding this comment.
Why do we need to do this? can't we use copydb_close_snapshot ?
| @@ -301,11 +312,23 @@ cli_compare_schema(int argc, char **argv) | |||
| exit(EXIT_CODE_INTERNAL_ERROR); | |||
| } | |||
|
|
|||
| if (!IS_EMPTY_STRING_BUFFER(compareOptions.snapshot) && !copydb_set_snapshot(©Specs)) | |||
There was a problem hiding this comment.
nitpicking: please make it fit in two lines, or even with embedded if statements, for ease of maintenance and also to respect line length (does it fit within 80 chars, per project policy).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to compare a source snapshot to the target
usecase: to check and make sure that data on source and target has not diverged when CDC has been ongoing for a while
pgcopydb follow --resumewith endpos set to the position the snapshot is at (e.g. 11/11111110)pgcopydb compare --snapshot 00000000-00000000-0can be used to compare