Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some copy paste errors #543

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Fix some copy paste errors #543

merged 3 commits into from
Nov 21, 2023

Conversation

hanefi
Copy link
Contributor

@hanefi hanefi commented Nov 16, 2023 •
edited
Loading

This is a small PR that aims to fix 2 small issues in the codebase.

  1. A comment that has a wrong file name. Possibly a copy paste error.
  2. A fatal log message that can misguide users into thinking that connections to target nodes have a problem where as the problem lies in setting some GUCs in connections to source postgres nodes.

@hanefi hanefi requested a review from dimitri November 16, 2023 19:01
@dimitri dimitri merged commit 00d7c57 into dimitri:main Nov 21, 2023
@dimitri dimitri added the bug Something isn't working label Nov 21, 2023
@hanefi hanefi deleted the fix-typos branch November 23, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitri dimitri dimitri approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanefi @dimitri