Recover from crash using undo log #549
Conversation
This commit remembers the file write position of a last successful transaction in a undo file. If there's a crash and we need to restart, we use this undo file to get rid of any partial work from the last transaction that wasn't finished. TODO: Can we use the undo log mechanism to even for graceful exit? This would simplify the code and make it uniform for both graceful and ungraceful exits/crashes. The idea is to undo the changes made by the last incomplete transaction by reading the undo log file and write other messages like ENDPOS. Signed-off-by: Arunprasad Rajkumar <[email protected]>
arajkumar
force-pushed
the
undo-log
branch
2 times, most recently
from
6c66270 to
e877bb6
Compare
|
I think implementing a proper undo log will become tricky to unless we resort to a transactional file write. Maybe opening the latest file and appending a ROLLBACK(if last txn is incomplete) will be much easier to implement. |
What if the latest/current transaction is incomplete and started several JSON files ago? |
It doesn't matter, all we do is appending a rollback message to latest file if we find the last statement is part of the incomplete txn. It is same as what we do for graceful exit. |
This commit remembers the file write position of a last successful transaction in
a undo file. If there's a crash and we need to restart, we use this undo file to get rid of any partial work from the last transaction that wasn't finished.
TODO: Can we use the undo log mechanism to even for graceful exit?
This would simplify the code and make it uniform for both graceful
and ungraceful exits/crashes. The idea is to undo the changes made
by the last incomplete transaction by reading the undo log file and
write other messages like ENDPOS.