Finish project #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinhquang252
force-pushed
the
finish_project
branch
from
01c3a56 to
773a90a
Compare
| minutes = (milliseconds % HOURS_TO_SECONDS) / ONE_HOUR; | ||
| seconds = ((milliseconds % HOURS_TO_SECONDS) % ONE_HOUR); | ||
| if (hours > 0) { | ||
| time = hours + ":" + minutes + ":" + seconds; |
There was a problem hiding this comment.
21 23 a khuyến khích em nên dùng StringFormat or StringBuilder.
Nếu em + String sẽ tạo ra nhiều vùng nhớ mới.
| ImageButton mImagePlay, mImageNext, mImageBack; | ||
| TextView mCurrentTime, mTotalTime; | ||
| Util mUtil = new Util(); |
| Intent startService = new Intent(this, ServicePlayMusic.class); | ||
| bindService(startService, mConnection, BIND_AUTO_CREATE); | ||
| startService(startService); | ||
|
|
| tools:context=".View.MainActivity" | ||
| tools:layout_editor_absoluteY="81dp"> | ||
|
|
||
| tools:context=".View.MainActivity"> | ||
|
|
||
| <ImageButton | ||
| android:id="@+id/imageBack" |
There was a problem hiding this comment.
| @@ -26,66 +26,70 @@ | |||
|
|
|||
| <ImageButton | |||
| android:id="@+id/imagePlay" | |||
There was a problem hiding this comment.
button_play or button_change_state. Convention 3.2
https://github.com/framgia/coding-standards/blob/master/eng/android/codingstyleguide.md
| app:layout_constraintEnd_toStartOf="@+id/imageNext" | ||
| app:layout_constraintHorizontal_bias="0.5" | ||
| app:layout_constraintStart_toEndOf="@+id/imageBack" | ||
| app:layout_constraintTop_toTopOf="parent" | ||
| app:srcCompat="@drawable/play" | ||
| app:srcCompat="@drawable/ic_play_button" | ||
| tools:ignore="MissingConstraints" /> | ||
|
|
||
| <ImageButton | ||
| android:id="@+id/imageNext" |
| tools:ignore="MissingConstraints" /> | ||
|
|
||
| <android.support.v7.widget.AppCompatSeekBar | ||
| android:id="@+id/BarSeek" | ||
| android:id="@+id/SeekBarMusic" |
|
|
||
| <TextView | ||
| android:id="@+id/txtCurrentTime" | ||
| android:id="@+id/textview_CurrentTime" |
app/src/main/res/values/dimens.xml
Outdated
| <dimen name="text_magin_end">289dp</dimen> | ||
| <dimen name="text_margin">16dp</dimen> | ||
| <dimen name="seekbar_margin_top">64dp</dimen> | ||
| </resources> |
dinhquang252
force-pushed
the
finish_project
branch
8 times, most recently
from
5753afa to
e1617f1
Compare
dinhquang252
force-pushed
the
finish_project
branch
from
e1617f1 to
9c677d8
Compare
NguyenMinhTuanB
approved these changes
Oct 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.