Store each program in a separate file #351
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the script at https://github.com/nikitastupin/diodb/blob/issue-346/tools/migrations/programs.py |
|
I would rather have all of them in one json file rather than 3000 individual json snippets |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋 This is a proof of concept for the idea proposed in #346. I've added a script to convert from
program-list.jsontoprogramsdirectory structure as discussed.If this looks good to you I'll add a workflow that will merge all programs to a single file on each push to
programsdirectory and push the file back to aprogram-list.json. In this way we'll preserve backward compatibility (though I'd prefer to publish the file on S3 / IPFS / whatever to keep the commit history clean).