Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: manage secrets for ai configuration #80

Merged
merged 11 commits into from
Oct 22, 2024
Merged

Feature: manage secrets for ai configuration #80

merged 11 commits into from
Oct 22, 2024

Conversation

Zorin95670
Copy link
Member

No description provided.

@Zorin95670 Zorin95670 added the enhancement New feature or request label Oct 17, 2024
@Zorin95670 Zorin95670 self-assigned this Oct 17, 2024
@Zorin95670 Zorin95670 force-pushed the feature/secrets branch 2 times, most recently from 7a234b6 to 308b9aa Compare October 17, 2024 09:44
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 17, 2024
View reviewed changes
src/main/java/com/ditrit/letomodelizerapi/service/ConfigurationSecretServiceImpl.java Outdated
SecretKeySpec secretKeySpec = new SecretKeySpec(keyBytes, "AES");

// Encrypt.
Cipher cipher = Cipher.getInstance("AES/CBC/PKCS5Padding");

Check failure

Code scanning / SonarCloud

Encryption algorithms should be used with secure mode and padding scheme

<!--SONAR_ISSUE_KEY:AZKZ47Y6V5UNA4qEdRN4-->Use another cipher mode or disable padding. <p>See more on <a href="https://sonarcloud.io/project/issues?id=ditrit_leto-modelizer-api&issues=AZKZ47Y6V5UNA4qEdRN4&open=AZKZ47Y6V5UNA4qEdRN4&pullRequest=80">SonarCloud</a></p>
src/main/java/com/ditrit/letomodelizerapi/service/ConfigurationSecretServiceImpl.java Outdated
SecretKeySpec secretKeySpec = new SecretKeySpec(keyBytes, "AES");

// Decrypt.
Cipher cipherDecrypt = Cipher.getInstance("AES/CBC/PKCS5Padding");

Check failure

Code scanning / SonarCloud

Encryption algorithms should be used with secure mode and padding scheme

<!--SONAR_ISSUE_KEY:AZKZ47Y6V5UNA4qEdRN5-->Use another cipher mode or disable padding. <p>See more on <a href="https://sonarcloud.io/project/issues?id=ditrit_leto-modelizer-api&issues=AZKZ47Y6V5UNA4qEdRN5&open=AZKZ47Y6V5UNA4qEdRN5&pullRequest=80">SonarCloud</a></p>
@Zorin95670 Zorin95670 force-pushed the feature/secrets branch 3 times, most recently from 39666cd to 842ef3b Compare October 17, 2024 12:44
@github-actions GitHub Actions
Copy link

: Project Dependency Updates (report to plain text file)

The following dependencies are using the latest milestone version:

  • com.adarshr.test-logger:com.adarshr.test-logger.gradle.plugin:4.0.0
  • com.github.ben-manes.versions:com.github.ben-manes.versions.gradle.plugin:0.51.0
  • com.puppycrawl.tools:checkstyle:10.12.5
  • commons-beanutils:commons-beanutils:1.9.4
  • commons-lang:commons-lang:2.6
  • info.solidsoft.pitest:info.solidsoft.pitest.gradle.plugin:1.15.0
  • io.cucumber:cucumber-java:7.20.1
  • io.cucumber:cucumber-junit:7.20.1
  • io.spring.dependency-management:io.spring.dependency-management.gradle.plugin:1.1.6
  • org.flywaydb:flyway-core:10.20.0
  • org.flywaydb:flyway-database-postgresql:10.20.0
  • org.jacoco:org.jacoco.agent:0.8.11
  • org.jacoco:org.jacoco.ant:0.8.11
  • org.junit.vintage:junit-vintage-engine:5.11.2
  • org.pitest:pitest-command-line:1.15.2
  • org.pitest:pitest-junit5-plugin:1.2.1
  • org.postgresql:postgresql:42.7.4
  • org.projectlombok:lombok:1.18.34
  • org.sonarqube:org.sonarqube.gradle.plugin:5.1.0.4882
  • org.springframework.boot:org.springframework.boot.gradle.plugin:3.3.4
  • org.springframework.boot:spring-boot-starter-actuator:3.3.4
  • org.springframework.boot:spring-boot-starter-data-jdbc:3.3.4
  • org.springframework.boot:spring-boot-starter-data-jpa:3.3.4
  • org.springframework.boot:spring-boot-starter-jersey:3.3.4
  • org.springframework.boot:spring-boot-starter-oauth2-client:3.3.4
  • org.springframework.boot:spring-boot-starter-security:3.3.4
  • org.springframework.boot:spring-boot-starter-test:3.3.4
  • org.springframework.boot:spring-boot-starter-validation:3.3.4
  • org.springframework.boot:spring-boot-starter-web:3.3.4
  • org.springframework.session:spring-session-jdbc:3.3.2

The following dependencies have later milestone versions:

Gradle release-candidate updates:

  • Gradle: [8.10.2 -> 8.11-rc-1]

@github-actions GitHub Actions
Copy link

Pit Test Coverage Report

Project Summary

Number of Classes Line Coverage Mutation Coverage Test Strength
72 94%
2000/2136
 81%
579/716
 84%
579/689

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
89.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Zorin95670 Zorin95670 merged commit 71f96e9 into main Oct 22, 2024
6 checks passed
@Zorin95670 Zorin95670 deleted the feature/secrets branch October 22, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aboubakar14 aboubakar14 aboubakar14 approved these changes

Assignees

@Zorin95670 Zorin95670

Labels
enhancement New feature or request
Projects
Board of Leto-modelizer
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zorin95670 @aboubakar14