chore: update todos

packages/common/index.ts

@@ -13,7 +13,6 @@ type Result<T, K extends string = "file"> =
 // TODO: bump this based on the latest state of the actual backend!
 
 export interface Backend {
-  // TODO: use resule
   getLinks: (dir: string) => Promise<Link[]>;
   getLink: (dir: string) => Promise<Result<Link, "link">>;
   getFile: (filepath: string) => Promise<Result<File>>;

packages/fuse-client/index.ts

@@ -1,5 +1,4 @@
 import { SQLiteBackend } from "@zoid-fs/sqlite-backend";
-// TODO: inline source as a package https://github.com/direktspeed/node-fuse-bindings
 import fuse from "@zoid-fs/node-fuse-bindings";
 import { rename } from "./syscalls/rename";
 import { unlink } from "./syscalls/unlink";
@@ -83,14 +82,14 @@ export class FuseClient {
         fsync: fsync(this.backend),
         fsyncdir: fsyncdir(this.backend),
         flush: flush(this.backend),
-        // lock: lock(this.backend), // TODO: implement in bindings
-        // bmap: bmap(this.backend), // TODO: implement in bindings
+        // lock: lock(this.backend), // Note: not implemented in bindings
+        // bmap: bmap(this.backend), // Note: not implemented in bindings
         setxattr: setxattr(this.backend),
         getxattr: getxattr(this.backend),
         listxattr: listxattr(this.backend),
         removexattr: removexattr(this.backend),
-        // ioctl: ioctl(this.backend), // TODO: implement in bindings
-        // poll: poll(this.backend), // TODO: implement in bindings
+        // ioctl: ioctl(this.backend), // Note: not implemented in bindings
+        // poll: poll(this.backend), // Note: not implemented in bindings
       },
       (err) => {
         if (err) {

packages/fuse-client/syscalls/fgetattr.ts

@@ -8,7 +8,6 @@ export const fgetattr: (backend: SQLiteBackend) => MountOptions["fgetattr"] = (
   return async (path, fd, cb) => {
     console.info("fgetattr -> getattr(%s, %d)", path, fd);
     //@ts-expect-error fix types
-    // TODO: implement fgetattr properly
     getattr(backend)?.(path, cb);
   };
 };

packages/fuse-client/syscalls/fsync.ts

@@ -2,15 +2,17 @@ import { SQLiteBackend } from "@zoid-fs/sqlite-backend";
 import { MountOptions } from "@zoid-fs/node-fuse-bindings";
 import { flush } from "./flush";
 
+/**
+ * We do buffered writes and flush flushes the buffer!
+ * A program may not call flush but fsync without relenquishing fd (like SQLite)
+ * In our case currently, the implementation of fsync and flush is same!
+ */
 export const fsync: (backend: SQLiteBackend) => MountOptions["fsync"] = (
   backend
 ) => {
   return async (path, fd, datasync, cb) => {
     console.info("fsync -> flush(%s, %d, %d)", path, fd, datasync);
-    // @ts-expect-error TODO: implement fsync properly
-    // We do buffered writes and flush flushes the buffer!
-    // A program may not call flush but fsync without relenquishing fd (like SQLite)
-    // In our case currently, the implementation of fsync and flush is same!
+    // @ts-expect-error fix types
     flush(backend)(path, fd, cb);
   };
 };

packages/fuse-client/syscalls/ftruncate.ts

@@ -8,7 +8,6 @@ export const ftruncate: (
   return async (path, fd, size, cb) => {
     console.info("ftruncate -> truncate(%s, %d, %d)", path, fd, size);
     //@ts-expect-error fix types
-    // TODO: implement ftruncate properly
     truncate(backend)(path, size, cb);
   };
 };

packages/fuse-client/syscalls/mknod.ts

@@ -8,7 +8,6 @@ export const mknod: (backend: SQLiteBackend) => MountOptions["mknod"] = (
   return async (path, mode, dev, cb) => {
     console.info("mknod -> create(%s, %d, %d)", path, mode, dev);
     //@ts-expect-error fix types
-    // TODO: implement mknod properly
     create(backend)(path, mode, cb);
   };
 };

packages/fuse-client/syscalls/symlink.ts

@@ -27,8 +27,6 @@ export const symlink: (backend: SQLiteBackend) => MountOptions["symlink"] = (
     const context = fuse.context();
     const { uid, gid } = context;
 
-    // TODO: double check if mode for symlink is correct
-    // https://unix.stackexchange.com/questions/193465/what-file-mode-is-a-symlink
     const r = await backend.createFile(
       destPath,
       "symlink",