Add from_credentials_json function. #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function can be used to initialize from a JSON string rather than a path to the credentials file. Closes djc#45.
djc
reviewed
Jan 23, 2022
|
Thanks for working on this! Still need to clean up the clippy lint, too. |
|
Thanks for reviewing and merging @djc ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #45.
This adds a
from_credentials_jsonfunction so that the credentials can be parsed from a JSON string.I changed
get_authentication_managersuch that instead of an optional path, one can pass anOption<CustomServiceAccount>. Thefrom_credentials_filefunction now handles the reading of the given path and thefrom_credentials_jsonhandles the reading of the given JSON.I updated the
init()function such that it first checksGOOGLE_APPLICATION_CREDENTIALSand if it exists, it will try to read from that path (if not it errors). If no such env variable exists, it callsget_authentication_managerwithNone.