WIP: 64bit sound fonts #126
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simotek
commented
Sep 14, 2024
|
|
||
| printf(" new CHAR %d\n", tRIFF.GetCkSize()); | ||
|
|
||
| // SL: IssueHere - This allocation fails, the test below ends up being NULL |
There was a problem hiding this comment.
The following check is failing suggesting that this allocation is failing. It might be related to the next comment.
simotek
commented
Sep 14, 2024
| if (dwLastFormID) | ||
| dwLastSize -= sizeof(DWORD); | ||
| // SL: IsssueHereMaybe. |
There was a problem hiding this comment.
Looking at dwLastSize, this line seems suspect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure how right it is but its getting a little closer, i'll add comments of where i got to.