Update path module to [email protected] #2821
Open
+1,973
−464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ PR OK, no changes in deprecations or warnings Total deprecations: 0 Total warnings: 0 Build statistics: statistics (-before, +after)
-executable size=5334536 bin/dub
-rough build time=62s
+executable size=5326624 bin/dub
+rough build time=63sFull build output |
Geod24
force-pushed
the
upgrade-path
branch
2 times, most recently
from
21620c6 to
5659959
Compare
Geod24
changed the title
Geod24
force-pushed
the
upgrade-path
branch
2 times, most recently
from
7cd408a to
26558a8
Compare
That looks like fun. |
|
Ubuntu: ==> Missing normalization At a glance, they all look related to normalization. |
Geod24
force-pushed
the
upgrade-path
branch
5 times, most recently
from
4bb5012 to
84c06c5
Compare
|
Only one test left failing: As well as some seemingly-unrelated vibe-core issue which vibe-d/vibe-core#421 might solve |
|
And now triggering a compiler bug on Windows, this is really a gift that keeps on giving. |
|
Needs more jpeg. I Can't read that at all. |
|
Geod24
force-pushed
the
upgrade-path
branch
6 times, most recently
from
8a7211c to
14b2c3c
Compare
The warnings are now issued regardless of whether DIP1000 is used or not, this just turns them into errors.
Currently our working directory is always the root, which means that we didn't care about absolute vs relative path.
On Windows, the root has a name, which is the drive, unlike on POSIX where the root is an empty name. This led to a flurry of problems because we assumed a POSIX style, where the FS is a directed graph, while on Windows it is multiple unconnected graphs (the drives cannot be accessed via a relative path).
Geod24
force-pushed
the
upgrade-path
branch
2 times, most recently
from
526b559 to
15a86fd
Compare
The root of an archive is `/`, not a drive letter. So while `NativePath` works here on POSIX, it will not make sense on Windows.
|
Running into a few issues here. Having the ability to differentiate Posix path from Windows path is great and all, but we need to provide a consistent serialization format for selection files. At the same time, we do want to accept Windows-only input. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.