Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return full asset on Manifest get #247

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Return full asset on Manifest get #247

merged 2 commits into from
Jan 29, 2025

Conversation

donaldgray
Copy link
Member

Reason for change was to populate "assets" on manifest GET with full details from DLCS.

Refactored some classes to accomodate this:

  • Renamed ManifestService -> ManifestWriteService and introduced an interface
  • Moves GetAssets from ManifestService to a new class, ManifestReadService, to allow it to be shared
  • Refactored code from GetManifest handler into ManifestReadService, and updated it to call GetAssets to read Asset data from DLCS.

@donaldgray donaldgray merged commit dd2bfda into main Jan 29, 2025
4 checks passed
@donaldgray donaldgray deleted the feature/fullasset_onget branch January 29, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants