fix: duplicate record display on rapid consecutive refreshes #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlvhdr
reviewed
May 11, 2024
dlvhdr
approved these changes
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses #294
I have implemented a modification to retain the TaskID for each fetch task within the model. This TaskID is identical to the one included in the msg sent upon the completion of a record fetch. Saving taskID within the model is a Last-Write-Wins basis, ensuring that only the most recent TaskID is stored in the model.
The PR and issue lists within the model are updated only if the TaskID in the model matches the TaskID in the incoming message.
How did you test this change?
I manually tested this change following the procedures shown in the video below. I confirmed that the issue was resolved without negatively impacting other functionalities such as paging or searching.
Images/Videos
gh-dash-pr02.mp4