Streamline custom commands #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes an assumption that specific data/keys are required by the bound command. Instead `Template.Option()` is used to tell the Template to error out if and when it actually encounters a key it needs.
Unfortuneatly it seems the Template options are a little lacking, and I don't believe can be persuaded to accept zero values or even nil pointers as 'missing' values. The struct in question, `PRCommandTemplateInput`, appears to have no use elsewhere however, so was easily replaced with a map, which I hope serves your needs for the near future at least.
…ifferent contexts
|
Following the calls back, could drop |
dlvhdr
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moved common functionality from
runCustomPRCommand()&runCustomIssueCommand()into newrunCustomCommand()functionHow did you test this change?
Set and ran rudimentary custom commands in each context. Could probably do with some more robust testing though tbh.
I've left an empty
inputmap still initialised in the new function, and merged in the specific data from the calls from different contexts, as I'm not sure what common data might want to be made available common to different contexts.