Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastify integration #174

Merged
merged 3 commits into from
Dec 3, 2024
Merged

fastify integration #174

merged 3 commits into from
Dec 3, 2024

Conversation

theoephraim
Copy link
Member

MVP of a fastify integration.

This is mostly just a standard node integration, however we can use a Fastify plugin for a few reasons. Aside from just feeling more native to the platform, we can:

  • automatically inject dmno globals
  • inject a hook/middleware to handle leak prevention
  • inject some behaviour into the standard pino logger instance

Copy link

changeset-bot bot commented Dec 3, 2024

🦋 Changeset detected

Latest commit: 663efe5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@dmno/fastify-integration Patch
dmno Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the maintainer Created by an official project maintainer label Dec 3, 2024
Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for signup-api canceled.

Name Link
🔨 Latest commit e1591ea
🔍 Latest deploy log https://app.netlify.com/sites/signup-api/deploys/674f6e5824fecf0008ca5b46

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for dmno ready!

Name Link
🔨 Latest commit e1591ea
🔍 Latest deploy log https://app.netlify.com/sites/dmno/deploys/674f6e58efd350000816cba3
😎 Deploy Preview https://deploy-preview-174--dmno.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Dec 3, 2024

Open in Stackblitz

npm i https://pkg.pr.new/dmno@174
npm i https://pkg.pr.new/@dmno/fastify-integration@174

commit: e1591ea

Copy link

cloudflare-workers-and-pages bot commented Dec 3, 2024

Deploying dmno with  Cloudflare Pages  Cloudflare Pages

Latest commit: e1591ea
Status: ✅  Deploy successful!
Preview URL: https://e7220c94.dmno.pages.dev
Branch Preview URL: https://fastify-integration.dmno.pages.dev

View logs

@theoephraim theoephraim force-pushed the fastify-integration branch 6 times, most recently from 1ea588a to 4d132b2 Compare December 3, 2024 07:47
Copy link
Contributor

@philmillman philmillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few nits, otherwise lgtm! :shipit:

@theoephraim theoephraim merged commit 08f165d into main Dec 3, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer Created by an official project maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants