-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: race condition with picked nodes #181
Conversation
🦋 Changeset detectedLatest commit: 0bbd0fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for dmno ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for signup-api canceled.
|
commit: |
84eb1cf
to
0bbd0fe
Compare
@@ -15,8 +15,9 @@ export function createdPickedValueResolver( | |||
// since we handle resolution of services in the right order | |||
// we can assume the picked value will be resolved already (if it was possible at all) | |||
if (!sourceNode.isResolved) { | |||
return new Error('picked value has not been resolved yet'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was returning an error as the result, which was getting serialized as [Object object]
. I think it went unnoticed because before the parallelization work, the source items were almost always resolved by the time they got picked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
fixes an issue with picked item resolution that was introduced when parallelized resolution was introduced. It went unnoticed because the pick tests still resolve correctly because everything was so simple. Introducing a short delay in that test recreates the issue.