-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce includeInDmnoConfig
option
#182
Conversation
✅ Deploy Preview for dmno ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for signup-api canceled.
|
fc294c7
to
31f19eb
Compare
🦋 Changeset detectedLatest commit: 31f19eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@dmno/configraph
dmno
@dmno/remix-integration
@dmno/vite-integration
@dmno/bitwarden-plugin
@dmno/1password-plugin
@dmno/encrypted-vault-plugin
@dmno/infisical-plugin
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
this lets items opt out of being included in the injected dmno config globals. This is useful for things like a 1password service account token which is needed to resolve your config, but never needed within your application. Especially when we are injecting resolved config into built code, we want to keep those values out of it.
The primary driver for this is keeping the cloudflare api token out of the built cloudflare worker code.