Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: update buildkit to v0.12.0, containerd v1.7.2 #4455

Closed
wants to merge 2 commits into from

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jul 20, 2023

vendor: github.com/containerd/containerd v1.7.2

full diff: https://github.com/containerd/containerd/compare/v1.6.21..v1.7.2

vendor: github.com/moby/buildkit v0.12.0

full diff: https://github.com/moby/buildkit/compare/v0.11.6..v0.12.0

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added this to the 25.0.0 milestone Jul 20, 2023
@thaJeztah
Copy link
Member Author

Actually, let me keep this as draft, and only update the (indirect) dependencies for now.

We don't necessarily need the buildkit update on the client-side, which could allow us to stick to containerd 1.6 (LTS) potentially?

The only parts of BuildKit used are;

tree vendor/github.com/moby/buildkit
vendor/github.com/moby/buildkit
├── AUTHORS
├── LICENSE
├── frontend
│   └── dockerfile
│       └── dockerignore
│           └── dockerignore.go
└── util
    ├── appcontext
    │   ├── appcontext.go
    │   ├── appcontext_unix.go
    │   ├── appcontext_windows.go
    │   └── register.go
    └── bklog
        └── log.go

6 directories, 8 files

@codecov-commenter
Copy link

Codecov Report

Merging #4455 (b809cec) into master (8837d11) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4455   +/-   ##
=======================================
  Coverage   59.39%   59.39%           
=======================================
  Files         288      288           
  Lines       24782    24782           
=======================================
  Hits        14720    14720           
  Misses       9175     9175           
  Partials      887      887           

@thaJeztah
Copy link
Member Author

closing in favour of #4605

@thaJeztah thaJeztah closed this Oct 13, 2023
@thaJeztah thaJeztah removed this from the 25.0.0 milestone Oct 13, 2023
@thaJeztah thaJeztah deleted the cli_bk_deps branch October 13, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants