Feature/seab 6279/angular material

[coverbeck]

Description
Upgrades to Angular MDC Material from the legacy components we are using today.

Why? Because Angular Material 17 dropped the legacy components. This means we can't upgrade to Angular 17 and stay current. Angular 16, our current version, is already no longer actively supported.

The Migration

• Following this guide.
• Main issues
  • Selectors in the cypress tests relying on "internal classes"
  • Styling (hard to find)

Review Instructions
Describe if this ticket needs review and if so, how one may go about it in qa and/or staging environments.
For example, a ticket based on Security Hub, Snyk, or Dependabot may not need review since those services
will generate new warnings if the issue has not been resolved properly. On the other hand, an infrastructure
ticket that results in visible changes to the end-user will definitely require review.
Many tickets will likely be between these two extremes, so some judgement may be required.

Issue
A link to a github issue or SEAB- ticket (using that as a prefix)

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

• Check that your code compiles by running npm run build
• Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
• If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
• Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
• If displaying markdown, use the markdown-wrapper component, which does extra sanitization
• Do not use cookies, although this may change in the future
• Run npm audit and ensure you are not introducing new vulnerabilities
• Do due diligence on new 3rd party libraries, checking for CVEs
• Don't allow user-uploaded images to be served from the Dockstore domain
• If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
• Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

[codecov]

Codecov Report

Attention: Patch coverage is 42.22222% with 104 lines in your changes missing coverage. Please review.

Project coverage is 41.82%. Comparing base (7e6c2d1) to head (659b354).
Report is 2 commits behind head on develop.

Files with missing lines	Patch %	Lines
...ations/collection/add-entry/add-entry.component.ts	0.00%	4 Missing and 3 partials ⚠️
...er-workflow/register-checker-workflow.component.ts	53.84%	5 Missing and 1 partial ⚠️
...ntainer/refresh-wizard/refresh-wizard.component.ts	0.00%	5 Missing ⚠️
...ion/github-apps-logs/github-apps-logs.component.ts	0.00%	3 Missing and 2 partials ⚠️
...container/register-tool/register-tool.component.ts	0.00%	4 Missing ⚠️
...terOrganization/register-organization.component.ts	0.00%	4 Missing ⚠️
.../shared/available-logs/available-logs.component.ts	0.00%	3 Missing and 1 partial ⚠️
.../app/shared/entry-wizard/entry-wizard.component.ts	20.00%	2 Missing and 2 partials ⚠️
...ry/doi/manage-dois/manage-dois-dialog.component.ts	20.00%	1 Missing and 3 partials ⚠️
...ab-topic/edit-topic/edit-topic-dialog.component.ts	55.55%	0 Missing and 4 partials ⚠️
... and 42 more

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #2052   +/-   ##
========================================
  Coverage    41.82%   41.82%           
========================================
  Files          395      395           
  Lines        12370    12370           
  Branches      2969     2969           
========================================
  Hits          5174     5174           
- Misses        4870     4871    +1     
+ Partials      2326     2325    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarqubecloud]

Quality Gate failed

Failed conditions
61.9% Coverage on New Code (required ≥ 80%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[coverbeck]

Latest status before transferring this. The good news is all integration and unit tests are passing. The bad news is:

• I haven't looked not tried, but I wouldn't be surprised if some of nightly smoke tests are using selectors that no longer exist.
• Known problems, and it's most likely not everything:

Dashboard, padding around Register Workflow button not right, plus Workflows not vertically centered

Dropdown on files tab has wrong background color, perhaps wrong font

Horizontal scrolling has crept back into versions tab, probably a font size issue, but just guessing

Left-side of dashboard totally off, padding, colors

Organizations page, content between different boxes not aligning. Compare to prod where the divider lines up exactly between boxes on the same row

Home page, starred-entries page. "chips" are larger, with the bonus of throwing off the wrapping on the home page