Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky UI Test fix 2 #2053

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Flaky UI Test fix 2 #2053

wants to merge 2 commits into from

Conversation

coverbeck
Copy link
Contributor

@coverbeck coverbeck commented Dec 20, 2024

Description
Steve pointed this out when he was running into flaky tests. Looking at videos of the failures, it looks like the previous dialog had not finished closing before proceeding, which threw off the tests. Fix has worked for me a few times.

Review Instructions
Not really reviewable; tests should pass.

Issue
None

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that your code compiles by running npm run build
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
  • Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
  • If displaying markdown, use the markdown-wrapper component, which does extra sanitization
  • Do not use cookies, although this may change in the future
  • Run npm audit and ensure you are not introducing new vulnerabilities
  • Do due diligence on new 3rd party libraries, checking for CVEs
  • Don't allow user-uploaded images to be served from the Dockstore domain
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
  • Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

@coverbeck coverbeck self-assigned this Dec 20, 2024
like previous dialog had not closed; I guess things
can get sluggish.
@coverbeck
Copy link
Contributor Author

Tests are failing. I haven't had a chance to look. I think they're failing somewhere unrelated to my fix. If the issue comes up again that @svonworl identified, I'd suggest cherry-picking this or investigating further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants