-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link sharing endpoint and modify community object for automatic DOI creation #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
denis-yuen
approved these changes
May 7, 2024
(security section and review missing, could be blanked in this case I guess) |
coverbeck
approved these changes
May 7, 2024
svonworl
approved these changes
May 7, 2024
Added a few more access link endpoints for deleting and getting a link. Re-requesting reviews |
denis-yuen
approved these changes
May 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review instructions ... could be blanked, can be reviewed as part of main ticket
svonworl
approved these changes
May 24, 2024
coverbeck
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Webservice PR: dockstore/dockstore#5879
This PR adds the POST endpoint for creating shared access links using the description from https://inveniordm.docs.cern.ch/reference/rest_api_drafts_records/#create-an-access-link.
Also modifies the existing DepositMetadata Community object so that the
id
field isidentifier
to match the Zenodo API docs. The invenio deposit metadata docs don't have communities listed, but it is in its future directions section. The FAQ section of this post says that it should be backwards compatible.Review Instructions
See dockstore/dockstore#5879
Issue
SEAB-6371 - link sharing
SEAB-5929 - automatic DOI creation
Security and Privacy
If there are any concerns that require extra attention from the security team, highlight them here.
e.g. Does this change...
no concerns
Please make sure that you've checked the following before submitting your pull request. Thanks!
mvn clean install
@RolesAllowed
annotation