Service definition changes for EntityValueResolver #1812
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eltharin
force-pushed
the
addTokenInEntityResolver
branch
3 times, most recently
from
a9ac7a8 to
b3b0dd3
Compare
Service Definition change for allow user inject its own variables in EntityValueResolver Symfony review change : EntityValueResolverVariableInjector to UserInjector
eltharin
force-pushed
the
addTokenInEntityResolver
branch
from
b3b0dd3 to
0a71f6e
Compare
stof
reviewed
Jul 12, 2024
| @@ -533,6 +534,12 @@ protected function ormLoad(array $config, ContainerBuilder $container) | |||
| $controllerResolverDefaults['evict_cache'] ?? null, | |||
| $controllerResolverDefaults['disabled'] ?? false, | |||
| ])); | |||
| } else { | |||
| $container->getDefinition('doctrine.orm.entity_value_resolver')->setArgument(2, (new Definition(MapEntity::class))); | |||
There was a problem hiding this comment.
If not I can't set my new argument, I have this error :
``
In DefinitionErrorExceptionPass.php line 48:
Invalid constructor argument 4 for service "doctrine.orm.entity_value_resolver": argument 3 must be defined before. Check your service definition.
``
There was a problem hiding this comment.
I can just remove the if to have only one initialisation.
eltharin
force-pushed
the
addTokenInEntityResolver
branch
3 times, most recently
from
789183f to
96e5b2d
Compare
correct psalm
eltharin
force-pushed
the
addTokenInEntityResolver
branch
from
96e5b2d to
b856ad0
Compare
|
Closing as the PR on Symfony side was also closed. See symfony/symfony#57676 (comment) |
|
Hello, what would be the solution to solve this problem? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related symfony/symfony#57676 for add a variableLoader service to inject in EntityValueResolver to allow user to have it's own variables (eg: user) in mapEntity