bump to phpstan level 4 #1859
Merged
bump to phpstan level 4 #1859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmaicher
commented
Jan 26, 2025
|
|
||
| $table = $definition->getArguments()[1]['db_table'] ?? 'sessions'; | ||
|
|
||
| if (! method_exists($definition->getClass(), 'configureSchema')) { |
There was a problem hiding this comment.
since method_exists($definition->getClass(), 'configureSchema') is alyways true now this class is no-op, right? 👀
There was a problem hiding this comment.
Indeed. Let's remove class too, since you already removed compiler pass definition anyways
There was a problem hiding this comment.
Yeah although its a BC break I would also tend to remove it as its completely useless now
dmaicher
force-pushed
the
phpstan-lvl-4
branch
from
1bc3ceb to
d82bf05
Compare
dmaicher
commented
Jan 26, 2025
ostrolucky
reviewed
Jan 26, 2025
|
|
||
| $table = $definition->getArguments()[1]['db_table'] ?? 'sessions'; | ||
|
|
||
| if (! method_exists($definition->getClass(), 'configureSchema')) { |
There was a problem hiding this comment.
Indeed. Let's remove class too, since you already removed compiler pass definition anyways
dmaicher
force-pushed
the
phpstan-lvl-4
branch
from
d82bf05 to
acda9f3
Compare
ostrolucky
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.